Some progress to handle notches / cutouts of #linuxmobile phones better in #phosh : I have a small lib that gets panel cutout / notch information as #svg paths and can calculate a bounding box . #phoc can use it to render cutouts for debugging and #phosh can use it for layout (so far only to shift the panel down). (see follow up posts for more pictures).
1️⃣ /4️⃣
phosh using that information to push the top panel down because there's a (simulated) notch:
3️⃣ /4️⃣
And this is how it looks on a device with notch. Also enabled PHOC_DEBUG=cutouts so phoc renders the bounding box of these.
If your device has a notch or cutout and you want #phosh to handle it automatically check https://phosh.mobi/posts/notch-support/ on how to describe the display properties.
@agx awesome! will use my dumb patch until this happens, thanks!
@agx awesome! will use my dumb patch until this happens, thanks!
@agx awesome! will use my dumb patch until this happens, thanks!
@agx awesome! will use my dumb patch until this happens, thanks!
@agx instead of pushing down, shouldn't it efficiently utilise the space, like not display any indicators in the notch area, but still effectively use the panel
@hemish read thw whole thing: https://social.librem.one/@agx/109682949493890985
@joao optional features (battery percentage, date, ...) are ignored for the calculation - there's not enough space (there isn't even enough space without a notch). There's also the language indicatore for example and the two kill switches.
Landscape: we don't clamp the space on purpose yet. That's a job for the compositor and we want some wayland protocol for that so it's a different topic.
@craftyguy @joao Interesting. That's basically what happens with this MR atm.
So no one will be able to say: look at how google does it ;)
heh, I have looked at Android source code a few times to see how they solved a problem I have been having. In general, the answer is they implimented the first thing I thought of but figured that wasnt a great idea.
*shrug*
MRs are linked here: https://gitlab.gnome.org/guidog/gmobile/-/merge_requests/8
Next steps (after cleaning up a bit and getting it merged) is allowing phosh to make better use of that information (e.g. to shift ui elements to the side instead of down) and providing the information to wayland clients so e.g. video players can make use of it in fullscreen mode.
4️⃣ /4️⃣